helm - add support for in-memory kubeconfig #497
Conversation
|
recheck |
|
recheck |
There was a problem hiding this comment.
In addition to these changes, this PR does not fully address the linked issue, as it does not add this functionality to the inventory plugin, the connection plugin or the lookup plugin. I think we can skip the inventory plugin as that will be deprecated in the next version. I'm not sure about the value of supporting this in the lookup plugin, as passing a dictionary in a lookup plugin seems pretty unwieldy, but I guess if someone wants to implement it we can consider it. It seems reasonable to support this for the connection plugin, though. If you don't want to do that in this PR, could you please either leave that issue open and add a note to it, or create a new issue for the pieces that weren't implemented?
I will add support for the connection plugin, it sounds reasonnable |
changelogs/fragments/497-helm-add-support-for-in-memory-kubeconfig.yml
Outdated
Show resolved
Hide resolved
…nfig.yml Co-authored-by: Mike Graves <mgraves@redhat.com>
SUMMARY
closes #492
ISSUE TYPE