Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-collections/news-for-maintainers#9 fixes #649

Merged
merged 6 commits into from
Mar 8, 2022

Conversation

D3DeFi
Copy link
Contributor

@D3DeFi D3DeFi commented Mar 8, 2022

SUMMARY

Sanity tests are failing as advertised in ansible-collections/news-for-maintainers#9

ISSUE TYPE
  • Bugfix Pull Request

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #649 (9d313ff) into main (393aa7a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files          25       25           
  Lines        3249     3249           
  Branches      837      837           
=======================================
  Hits         2418     2418           
  Misses        561      561           
  Partials      270      270           
Impacted Files Coverage Δ
...nity/zabbix/plugins/modules/zabbix_autoregister.py 82.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 393aa7a...9d313ff. Read the comment docs.

@D3DeFi
Copy link
Contributor Author

D3DeFi commented Mar 8, 2022

@felixfontein related to ansible-collections/news-for-maintainers#9, can you please provide some guidance here? Not sure how is this supposed to work with connection plugins

not sure what else to add here:

ERROR: Found 2 validate-modules issue(s) which need to be resolved:
ERROR: plugins/connection/httpapi.py:0:0: invalid-documentation: DOCUMENTATION.name: not a valid value for dictionary value @ data['name']. Got 'zabbix'
ERROR: plugins/httpapi/jsonrpc.py:0:0: invalid-documentation: DOCUMENTATION.name: not a valid value for dictionary value @ data['name']. Got 'zabbix'

plugins/connection/httpapi.py Outdated Show resolved Hide resolved
plugins/httpapi/jsonrpc.py Outdated Show resolved Hide resolved
D3DeFi and others added 2 commits March 8, 2022 13:38
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
@D3DeFi
Copy link
Contributor Author

D3DeFi commented Mar 8, 2022

thanks a lot @felixfontein ! :) I wouldn't guess

@D3DeFi D3DeFi mentioned this pull request Mar 8, 2022
@D3DeFi D3DeFi merged commit fa779d3 into ansible-collections:main Mar 8, 2022
@D3DeFi D3DeFi deleted the sanity-fixes branch March 8, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants