-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic user/password in .my.cnf #89
Conversation
@mrpk1906 Can you also add a bugfix changelog fragment? |
For convenience, there's a link to changelog doc https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment |
Hi @markuman @Andersson007 Please check :) |
changelogs/fragments/89-dynamic-user-password-in-client-my-cnf-and-correct-package-name.yml
Outdated
Show resolved
Hide resolved
…-and-correct-package-name.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of changelog LGTM.
If this role didn't work with python-mysqldb
and after this PR gets merged it will work, LGTM
hmmm, maybe it works on focal (ubuntu 20.04) with that. And maybe it breaks xenial (ubuntu 16.04)? I'll try to verify next days. |
Tested with bionic and focal ... the role runs in other errors that are not related to that PR. @mrpk1906 Thanks for your contribution. |
User and password in .my.cnf hardcoded to admin/admin
This pull request to allow set dynamic user/pass to proxysql admin