Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new module proxysql_galera_hostgroups #147

Merged
merged 5 commits into from
May 17, 2024

Conversation

tompal3
Copy link
Contributor

@tompal3 tompal3 commented Nov 16, 2023

SUMMARY

Add new role for managing mysql_galera_hostgroups table in proxysql

as discused in: #6

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

proxysql_galera_hostgroups

ADDITIONAL INFORMATION

@tompal3 tompal3 changed the title Add new role proxysql_galera_hostgroups Add new module proxysql_galera_hostgroups Nov 16, 2023
@markuman
Copy link
Member

ERROR: tests/integration/targets/test_proxysql_galera_hostgroups/tasks/main.yml:178:1: empty-lines: too many blank lines (4 > 3) (100%)

@tompal3
Copy link
Contributor Author

tompal3 commented Nov 17, 2023

@tompal3
Copy link
Contributor Author

tompal3 commented Nov 20, 2023

@markuman sorry for bothering but this is my first contribution and I was wondering what is proper way to ask someone to review it?

@markuman markuman merged commit d45ded1 into ansible-collections:main May 17, 2024
12 checks passed
Copy link

patchback bot commented May 17, 2024

Backport to stable-1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1/d45ded1ec8cd3f260ed5620b217520a272e5f70e/pr-147

Backported as #155

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 17, 2024
* Add new role proxysql_galera_hostgroups

* fix documentation and examples

* empty commit to init workflow

* fix sanity test errors

* trailing spaces fix

(cherry picked from commit d45ded1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants