Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping Python 2 & 3.5 Support #81

Closed
briantist opened this issue May 20, 2021 · 1 comment · Fixed by #177
Closed

Dropping Python 2 & 3.5 Support #81

briantist opened this issue May 20, 2021 · 1 comment · Fixed by #177
Milestone

Comments

@briantist
Copy link
Collaborator

briantist commented May 20, 2021

UPDATE: Python 3.5 support will also be dropped

As clarified in the hvac thread, support for Python 3.5 will also be dropped along with 2.x, and for the same reasons below, this collection won't be able to easily support 3.5.

Python 3.6 will be the minimum version for community.hashi_vault starting in version 2.0.0, keeping parity with hvac.


Python 2 Support Will be Dropped in v2

As of the next major version, v2 (v2.0.0+) release of community.hashi_vault, Python 2 will no longer be directly supported or tested against. At that time the minimum Python version will likely be Python 3.5, or 3.6 (tbd).

Why?

We all know Py2 is EoL and projects are dropping support for it left and right, including Ansible (on the controller, where currently all content in this collection runs). This makes it harder and harder to keep supporting it, to work around CI and testing issues too. But the major driver for this decision is around the hvac library.

All of the content in this collection currently relies on hvac and is expected to indefinitely.

hvac still supports Python2, for now, however:

Even if hvac does not explicitly drop support, it's clear the lack of testing against it is a problem, and given the other difficulty of continuing to support it, I feel announcing the end of support in this collection's next major version is prudent.


This post will be updated with more information as it becomes available.

@briantist briantist added this to the v2.0.0 milestone May 20, 2021
@briantist briantist pinned this issue May 20, 2021
This was referenced May 20, 2021
@briantist briantist changed the title Dropping Python 2 Support Dropping Python 2 & 3.5 Support Jul 13, 2021
@briantist
Copy link
Collaborator Author

briantist commented Aug 1, 2021

List of things to check/change

just trying to keep a running list of stuff in place so I don't forget. I'm sure more will turn up.

  • github workflows
  • tests/config.yml -- update the required versions (this will only work in 2.12+ but still)
  • tests/integrations/requirements.txt
  • tests/unit/requirements.txt
  • tests/unit/* check for areas where manual python version exclusion was needed (for 2.6). We'll likely need more of that to exclude 2.7 and 3.5 on ansible-core <=2.11 since tests/config.yml isn't supported on those
  • re-evaluate some of the try/import blocks to see if some of the fallbacks are even needed anymore, or could be made better
  • update the comments in module & plugin utils code about supported versions of python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant