Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vault_token_create orphan support to use new hvac method #301

Closed
briantist opened this issue Sep 13, 2022 · 1 comment · Fixed by #303
Closed

Update vault_token_create orphan support to use new hvac method #301

briantist opened this issue Sep 13, 2022 · 1 comment · Fixed by #303
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@briantist
Copy link
Collaborator

briantist commented Sep 13, 2022

SUMMARY

The method in hvac that can be used to create orphan tokens through the /create-orphan endpoint is deprecated for removal in v1, but had no replacement.

With hvac/hvac#869 a replacement is being introduced for the 1.0.0 release.

We'll need to update vault_token_create to use this new method.

We will prefer this one, but also fall back to the old one, so that we keep compatibility with older versions of hvac for a bit.

The best-effort fallback to the method that requires root can be removed without deprecation; it was put in place as a potential fallback in case hvac 1.0.0 was released with no replacement, so with a replacement now there's no need to use it.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

vault_token_create

@briantist briantist added the enhancement New feature or request label Sep 13, 2022
@briantist briantist added this to the v3.3.0 milestone Sep 13, 2022
@briantist briantist self-assigned this Sep 13, 2022
@briantist
Copy link
Collaborator Author

Now that hvac 1.0.0 is out the integration tests are broken until this issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant