retries - urllib3
fallback import from vendored version in requests
is not correct
#116
Labels
bug
Something isn't working
SUMMARY
In implementing retries, we need
urllib3.util.Retry
. We first try to import a standalone version ofurllib3
, which is usually available.We have a fallback in case that fails to try to import via the
requests
library, which has a vendored version ofurllib3
as well:However this is not the correct form; instead we must import
urllib3
as a module:And then use it from there.
See: https://docs.python-requests.org/en/master/community/updates/#id25
No bug reports or issues in the wild have yet come up as a result of this, to my knowledge.
ISSUE TYPE
COMPONENT NAME
ANSIBLE VERSION
COLLECTION VERSION
CONFIGURATION
OS / ENVIRONMENT
STEPS TO REPRODUCE
EXPECTED RESULTS
ACTUAL RESULTS
The text was updated successfully, but these errors were encountered: