Define python_requires for ansible-test
#348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamercad
requested review from
Akasurde,
bmildren,
danxg87,
geerlingguy,
mpontillo and
tparker00
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 64.03% 60.90% -3.14%
==========================================
Files 46 46
Lines 3617 3619 +2
Branches 743 743
==========================================
- Hits 2316 2204 -112
- Misses 995 1136 +141
+ Partials 306 279 -27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gotmax23
suggested changes
Jan 24, 2024
| - ansible-core >= 2.12 (not including `devel`) | ||
| - ansible-core >= 2.14 (not including `devel`) |
There was a problem hiding this comment.
Can dropping support for ansible-core 2.12 and 2.13 be split out into a separate change? Dropping support for old ansible-core versions warrants a new major release and isn't really related to the issue at hand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #347.