fix(cdk/dialog): add container structural styles #24905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the CDK dialog container doesn't come with any styles which means that it's `display: inline`, making it difficult to change its size. These changes add a handful of styles to make it match the specified size in the config.
crisbeto
added
P3
jelbourn
approved these changes
May 11, 2022
| @@ -0,0 +1,13 @@ | |||
| .cdk-dialog-container { | |||
There was a problem hiding this comment.
I might add a comment for the whole class that mentions the intent is to provide the bare minimum styles to make the container behave reasonably, with most of the customization expected to be done by the consumer of CdkDialog
There was a problem hiding this comment.
The consumer isn't expected to customize this component, but the one inside it or the container around it.
crisbeto
added a commit
that referenced
this pull request
May 11, 2022
Currently the CDK dialog container doesn't come with any styles which means that it's `display: inline`, making it difficult to change its size. These changes add a handful of styles to make it match the specified size in the config. (cherry picked from commit 32a8b38)
This was referenced May 29, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CDK dialog container doesn't come with any styles which means that it's
display: inline, making it difficult to change its size. These changes add a handful of styles to make it match the specified size in the config.