Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<source> tag throwing error since alpha.48 (d388c0a) #5663

Closed
markharding opened this issue Dec 7, 2015 · 2 comments
Closed

<source> tag throwing error since alpha.48 (d388c0a) #5663

markharding opened this issue Dec 7, 2015 · 2 comments

Comments

@markharding
Copy link

It appears that angular2 wants the <source .. > tag to be closed. <source ..> and are both invalid according to w3 spec (as far as I know).

Markup:

<video autoplay muted loop poster="assets/videos/traffic-1/traffic-1.png">
      <source src="assets/videos/traffic-1/traffic-1.webm" type="video/webm">
      <source src="assets/videos/traffic-1/traffic-1.mp4" type="video/mp4">
</video>

Console log:

EXCEPTION: Template parse errors:
Unexpected closing tag "video" ("ideo/webm">
          <source src="assets/videos/traffic-1/traffic-1.mp4" type="video/mp4">
        [ERROR ->]</video>
      </div>
      <div class="overlay">
"): e@6:8
Unexpected closing tag "div" ("       <source src="assets/videos/traffic-1/traffic-1.mp4" type="video/mp4">
        </video>
      [ERROR ->]</div>
      <div class="overlay">
        <img src="assets/logos/medium-white.png" class="m-logo"/>
"): e@7:6

Ref: http://www.w3.org/TR/html-markup/source.html

@woppa684
Copy link

woppa684 commented Dec 7, 2015

"source" is a void element and should NOT be closed indeed, so, what you're saying should be correct, see also #5563

pkozlowski-opensource added a commit to pkozlowski-opensource/angular that referenced this issue Dec 7, 2015
pkozlowski-opensource added a commit to pkozlowski-opensource/angular that referenced this issue Dec 7, 2015
pkozlowski-opensource added a commit to pkozlowski-opensource/angular that referenced this issue Dec 7, 2015
pkozlowski-opensource added a commit to pkozlowski-opensource/angular that referenced this issue Dec 7, 2015
pkozlowski-opensource added a commit to pkozlowski-opensource/angular that referenced this issue Dec 7, 2015
vicb pushed a commit to vicb/angular that referenced this issue Dec 8, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants