Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror dom property values as attribute values in debug mode #2910

Closed
naomiblack opened this issue Jul 7, 2015 · 4 comments · Fixed by #3072
Closed

Mirror dom property values as attribute values in debug mode #2910

naomiblack opened this issue Jul 7, 2015 · 4 comments · Fixed by #3072
Assignees
@jeffbcross
Labels
effort2: days feature Issue that requests a new feature
Milestone
alpha-32

Comments

@naomiblack
Copy link
Contributor

This is needed for web workers and other use cases, to make it easy to locate elements by binding. Assigning to @tbosch to spec out and figure out who should best implement.
@naomiblack naomiblack added feature Issue that requests a new feature hotlist: GT effort2: days labels Jul 7, 2015
@naomiblack naomiblack added this to the alpha-32 milestone Jul 7, 2015
@naomiblack
Copy link
Contributor Author

Also cited in internal b/21869186

@tbosch tbosch modified the milestone: alpha-32 Jul 11, 2015
@naomiblack naomiblack added this to the alpha-32 milestone Jul 13, 2015
@naomiblack naomiblack assigned tbosch and jeffbcross and unassigned tbosch Jul 13, 2015
@jeffbcross
Copy link
Contributor

We'll create a token in the root injector called DOM_REFLECT_PROPERTIES_AS_ATTRIBUTES with a default value of false. It's up to the user to set this value to true if they want properties to be reflected as attributes.

@jeffbcross
Copy link
Contributor

Attributes will all be dash-cased, with a prefix of "ng-reflect-".

jeffbcross added a commit to jeffbcross/angular that referenced this issue Jul 15, 2015
@jeffbcross
feat(core): add ability to reflect DOM properties as attributes
f3544ed 
By binding the token `DOM_REFLECT_PROPERTIES_AS_ATTRIBUTES` provided by 
the dom_renderer module to `true` in the root injector (i.e. bootstrap()), 
all elements whose properties are set by angular will be reflected as 
attributes with the prefix "ng-reflect-".

Fixes angular#2910
jeffbcross added a commit to jeffbcross/angular that referenced this issue Jul 15, 2015
@jeffbcross
feat(core): add ability to reflect DOM properties as attributes
bb708d5 
By binding the token `DOM_REFLECT_PROPERTIES_AS_ATTRIBUTES` provided by 
the dom_renderer module to `true` in the root injector (i.e. bootstrap()), 
all elements whose properties are set by angular will be reflected as 
attributes with the prefix "ng-reflect-".

Fixes angular#2910
@jeffbcross jeffbcross mentioned this issue Jul 15, 2015
Merged
jeffbcross added a commit to jeffbcross/angular that referenced this issue Jul 15, 2015
@jeffbcross
feat(core): add ability to reflect DOM properties as attributes
27ad9f5 
By binding the token `DOM_REFLECT_PROPERTIES_AS_ATTRIBUTES` provided by 
the dom_renderer module to `true` in the root injector (i.e. bootstrap()), 
all elements whose properties are set by angular will be reflected as 
attributes with the prefix "ng-reflect-".

Fixes angular#2910
jeffbcross added a commit to jeffbcross/angular that referenced this issue Jul 15, 2015
@jeffbcross
feat(core): add ability to reflect DOM properties as attributes
903ff90 
By binding the token `DOM_REFLECT_PROPERTIES_AS_ATTRIBUTES` provided by 
the dom_renderer module to `true` in the root injector (i.e. bootstrap()), 
all elements whose properties are set by angular will be reflected as 
attributes with the prefix "ng-reflect-".

Fixes angular#2910
@arlowhite arlowhite mentioned this issue Feb 7, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeffbcross jeffbcross

Labels
effort2: days feature Issue that requests a new feature
Projects
None yet
Milestone
alpha-32
Development

Successfully merging a pull request may close this issue.

feat(core): add ability to reflect DOM properties as attributes jeffbcross/angular
3 participants
@jeffbcross @tbosch @naomiblack