This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($resource): Always return a resource instance when calling class met... #5061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $httpBackend.expect('POST', '/Person').respond('\n{\n"name":\n"misko2"\n}\n'); | ||
| var person2 = Person.save(person); | ||
| expect(person2 instanceof Person).toBe(true) |
There was a problem hiding this comment.
This can be
expect(person2).toEqual(jasmine.any(Person));
|
Other than changing the test description, as you suggest and my comments above, this looks good to me. |
…methods on resources.
Previously, calling `MyResource.save(myResourceInstance)`returned
a promise, in contrast to the docs for `$resource`. However,
calling `MyResource.save({name: 'Tobias"})`already correctly
returned a resource instance.
Fixes angular#4545.
|
Hi Pete, thanks for your comments. Changed it accordingly. |
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
…methods on resources.
Previously, calling `MyResource.save(myResourceInstance)`returned
a promise, in contrast to the docs for `$resource`. However,
calling `MyResource.save({name: 'Tobias"})`already correctly
returned a resource instance.
Fixes angular#4545.
Closes angular#5061.
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
…methods on resources.
Previously, calling `MyResource.save(myResourceInstance)`returned
a promise, in contrast to the docs for `$resource`. However,
calling `MyResource.save({name: 'Tobias"})`already correctly
returned a resource instance.
Fixes angular#4545.
Closes angular#5061.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...hods on resources.
Previously, calling
MyResource.save(myResourceInstance)returneda promise, in contrast to the docs for
$resource. However,calling
MyResource.save({name: 'Tobias"})already correctlyreturned a resource instance.
Fixes #4545.