Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): add "type" option in enum schematic #20670

Merged
merged 1 commit into from
May 3, 2021

Conversation

mephistorine
Copy link
Contributor

@mephistorine mephistorine commented Apr 30, 2021

closes: #20667

@google-cla google-cla bot added the cla: yes label Apr 30, 2021
@mephistorine mephistorine changed the title Enum schematic fix fix(@angular-devkit/schematics) add "type" option in enum schematic Apr 30, 2021
@mephistorine mephistorine changed the title fix(@angular-devkit/schematics) add "type" option in enum schematic fix(@angular-devkit/schematics): add "type" option in enum schematic Apr 30, 2021
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Couple of things

  • Can you please drop the first commit?
  • Kindly use @schematics/angular as commit message scope.
  • Add closes: #20667 as commit message footer.

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 30, 2021
@mephistorine
Copy link
Contributor Author

@alan-agius4 thanks, ok.

@mephistorine mephistorine force-pushed the enum-schematic-fix branch 2 times, most recently from fa57fc0 to 6eb34d9 Compare May 1, 2021 20:13
@mephistorine mephistorine changed the title fix(@angular-devkit/schematics): add "type" option in enum schematic fix(@schematics/angular): add "type" option in enum schematic May 1, 2021
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 1, 2021
@alan-agius4 alan-agius4 removed the action: merge The PR is ready for merge by the caretaker label May 1, 2021
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

Can you kindly squash the commits? Thanks.

@mephistorine
Copy link
Contributor Author

@alan-agius4 yes, give a second. :)

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 1, 2021
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mephistorine
Copy link
Contributor Author

@alan-agius4 Thanks a lot 😃

@clydin clydin merged commit 1b9577a into angular:master May 3, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add type option in enum generate like interface or class
3 participants