-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@schematics/angular): add "type" option in enum schematic #20670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
Couple of things
- Can you please drop the first commit?
- Kindly use
@schematics/angular
as commit message scope. - Add
closes: #20667
as commit message footer.
@alan-agius4 thanks, ok. |
fa57fc0
to
6eb34d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution.
Can you kindly squash the commits? Thanks.
@alan-agius4 yes, give a second. :) |
f19d73f
to
2ececf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
@alan-agius4 Thanks a lot 😃 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
closes: #20667