Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different tslint typedef behavior between migration and generation #18465

Closed
2 of 15 tasks
Bored-Bohr opened this issue Aug 6, 2020 · 1 comment · Fixed by #20291
Closed
2 of 15 tasks

Different tslint typedef behavior between migration and generation #18465

Bored-Bohr opened this issue Aug 6, 2020 · 1 comment · Fixed by #20291
Assignees
Labels
area: @schematics/angular feature Issue that requests a new feature

Comments

@Bored-Bohr
Copy link

🐞 Bug report

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • xi18n
  • run
  • config
  • help
  • version
  • doc

Description

When migrating from Angular 9 using ng update @angular/core @angular/cli the typedef rule is not added to tslint.json.
When generating a new project in Angular 10, the typedef rule is added.

It seems that typedef should be added with Angular 10 #17821

🔬 Minimal Reproduction

Migration

  1. Install Angular CLI 9: npm i -g @angular/cli@v9-lts
  2. Generate Angular 9: ng new <project_name>
  3. cd <project_name>
  4. Update to Angular 10: ng update @angular/core @angular/cli

Generation

  1. Install Angular CLI 9: npm i -g @angular/cli@latest
  2. Generate Angular 10: ng new <project_name>

Check difference in tslint.json

🌍 Your Environment

Angular CLI: 9.1.12
Node: 12.18.3
OS: win32 x64

Angular CLI: 10.0.5
Node: 12.18.3
OS: win32 x64

Anything else relevant?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.