-
Notifications
You must be signed in to change notification settings - Fork 12k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(@schematics/angular): add migration to use new zone.js entry-points
- Loading branch information
1 parent
f309516
commit 7d57dd2
Showing
4 changed files
with
227 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 changes: 90 additions & 0 deletions
90
packages/schematics/angular/migrations/update-12/update-zonejs.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
/** | ||
* @license | ||
* Copyright Google Inc. All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
import { join } from '@angular-devkit/core'; | ||
import { DirEntry, Rule } from '@angular-devkit/schematics'; | ||
import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks'; | ||
import { addPackageJsonDependency, getPackageJsonDependency } from '../../utility/dependencies'; | ||
|
||
const fileExtensionRegexp = /\.(([cm]?j|t)sx?)$/; | ||
|
||
function* visitJavaScriptFiles(directory: DirEntry): IterableIterator<string> { | ||
for (const path of directory.subfiles) { | ||
if (!fileExtensionRegexp.test(path)) { | ||
continue; | ||
} | ||
|
||
yield join(directory.path, path); | ||
} | ||
|
||
for (const path of directory.subdirs) { | ||
if (path === 'node_modules' || path.startsWith('.') || path === 'dist') { | ||
continue; | ||
} | ||
|
||
yield* visitJavaScriptFiles(directory.dir(path)); | ||
} | ||
} | ||
|
||
export default function (): Rule { | ||
return (tree, context) => { | ||
const current = getPackageJsonDependency(tree, 'zone.js'); | ||
if (current && current.version !== '~0.11.4') { | ||
addPackageJsonDependency(tree, { | ||
type: current.type, | ||
name: 'zone.js', | ||
version: '~0.11.4', | ||
overwrite: true, | ||
}); | ||
|
||
context.addTask(new NodePackageInstallTask()); | ||
} | ||
|
||
for (const path of visitJavaScriptFiles(tree.root)) { | ||
const buffer = tree.read(path); | ||
if (!buffer) { | ||
return; | ||
} | ||
|
||
const content = buffer.toString(); | ||
if (!content.includes('zone.js/dist/')) { | ||
continue; | ||
} | ||
|
||
// RegExp that replaces | ||
// - import 'zone.js/dist/zone-testing' -> import 'zone.js/testing' | ||
// - require('zone.js/dist/zone-testing') -> require('zone.js/testing') | ||
// - import 'zone.js/dist/zone' -> import 'zone.js' | ||
// - require('zone.js/dist/zone') -> require('zone.js') | ||
// - import 'zone.js/dist/zone-error' -> import 'zone.js/plugins/zone-error' | ||
// - require('zone.js/dist/zone-error') -> require('zone.js/plugins/zone-error') | ||
tree.overwrite( | ||
path, | ||
content | ||
.replace( | ||
/(?<=(?:require\s*\(|import\s+)['"]zone\.js)\/dist\/zone-?\w*(?=['"]\)?)/g, | ||
match => { | ||
switch (match) { | ||
case '/dist/zone': | ||
case '/dist/zone-evergreen': | ||
return ''; | ||
case '/dist/zone-testing': | ||
case '/dist/zone-evergreen-testing': | ||
return '/testing'; | ||
case '/dist/zone-node': | ||
return '/node'; | ||
case '/dist/zone-mix': | ||
return '/mix'; | ||
default: | ||
return `/plugins${match.substr(5)}`; | ||
} | ||
}, | ||
), | ||
); | ||
} | ||
}; | ||
} |
131 changes: 131 additions & 0 deletions
131
packages/schematics/angular/migrations/update-12/update-zonejs_spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,131 @@ | ||
/** | ||
* @license | ||
* Copyright Google Inc. All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
import { EmptyTree } from '@angular-devkit/schematics'; | ||
import { SchematicTestRunner, UnitTestTree } from '@angular-devkit/schematics/testing'; | ||
import { getPackageJsonDependency } from '../../utility/dependencies'; | ||
|
||
const schematicName = 'update-zonejs'; | ||
describe(`Migration to update 'zone.js' to 0.11.x. ${schematicName}`, () => { | ||
const schematicRunner = new SchematicTestRunner( | ||
'migrations', | ||
require.resolve('../migration-collection.json'), | ||
); | ||
|
||
let tree: UnitTestTree; | ||
beforeEach(() => { | ||
tree = new UnitTestTree(new EmptyTree()); | ||
tree.create('/package.json', JSON.stringify({ 'dependencies': { 'zone.js': '~0.10.0' } }, undefined, 2)); | ||
}); | ||
|
||
it(`should update 'zone.js' dependency in 'package.json'`, async () => { | ||
const newTree = await schematicRunner.runSchematicAsync(schematicName, {}, tree).toPromise(); | ||
expect(getPackageJsonDependency(newTree, 'zone.js')?.version).toBe('~0.11.4'); | ||
}); | ||
|
||
it(`should update 'zone.js/dist/zone' import`, async () => { | ||
tree.create('file.ts', ` | ||
import 'zone.js'; | ||
import 'zone.js/dist/zone'; | ||
import "zone.js/dist/zone"; | ||
// import "zone.js/dist/zone"; | ||
`); | ||
|
||
const newTree = await schematicRunner.runSchematicAsync(schematicName, {}, tree).toPromise(); | ||
expect(newTree.readContent('file.ts')).toBe(` | ||
import 'zone.js'; | ||
import 'zone.js'; | ||
import "zone.js"; | ||
// import "zone.js"; | ||
`); | ||
}); | ||
|
||
it(`should update 'zone.js/dist/zone' require`, async () => { | ||
tree.create('file.ts', ` | ||
require('zone.js'); | ||
require('zone.js/dist/zone'); | ||
require("zone.js/dist/zone"); | ||
// require("zone.js/dist/zone"); | ||
`); | ||
|
||
const newTree = await schematicRunner.runSchematicAsync(schematicName, {}, tree).toPromise(); | ||
expect(newTree.readContent('file.ts')).toBe(` | ||
require('zone.js'); | ||
require('zone.js'); | ||
require("zone.js"); | ||
// require("zone.js"); | ||
`); | ||
}); | ||
|
||
it(`should update 'zone.js/dist/zone-error' import`, async () => { | ||
tree.create('file.ts', ` | ||
import 'zone.js/plugins/zone-error'; | ||
import 'zone.js/dist/zone-error'; | ||
import "zone.js/dist/zone-error"; | ||
// import "zone.js/dist/zone-error"; | ||
`); | ||
|
||
const newTree = await schematicRunner.runSchematicAsync(schematicName, {}, tree).toPromise(); | ||
expect(newTree.readContent('file.ts')).toBe(` | ||
import 'zone.js/plugins/zone-error'; | ||
import 'zone.js/plugins/zone-error'; | ||
import "zone.js/plugins/zone-error"; | ||
// import "zone.js/plugins/zone-error"; | ||
`); | ||
}); | ||
|
||
it(`should update 'zone.js/dist/zone-error' require`, async () => { | ||
tree.create('file.ts', ` | ||
require('zone.js/plugins/zone-error'); | ||
require('zone.js/dist/zone-error'); | ||
require("zone.js/dist/zone-error"); | ||
// require("zone.js/dist/zone-error"); | ||
`); | ||
|
||
const newTree = await schematicRunner.runSchematicAsync(schematicName, {}, tree).toPromise(); | ||
expect(newTree.readContent('file.ts')).toBe(` | ||
require('zone.js/plugins/zone-error'); | ||
require('zone.js/plugins/zone-error'); | ||
require("zone.js/plugins/zone-error"); | ||
// require("zone.js/plugins/zone-error"); | ||
`); | ||
}); | ||
|
||
it(`should update 'zone.js/dist/zone-testing' import`, async () => { | ||
tree.create('file.ts', ` | ||
import 'zone.js/testing'; | ||
import 'zone.js/dist/zone-testing'; | ||
import "zone.js/dist/zone-testing"; | ||
// import "zone.js/dist/zone-testing"; | ||
`); | ||
|
||
const newTree = await schematicRunner.runSchematicAsync(schematicName, {}, tree).toPromise(); | ||
expect(newTree.readContent('file.ts')).toBe(` | ||
import 'zone.js/testing'; | ||
import 'zone.js/testing'; | ||
import "zone.js/testing"; | ||
// import "zone.js/testing"; | ||
`); | ||
}); | ||
|
||
it(`should update 'zone.js/dist/zone-testing' require`, async () => { | ||
tree.create('file.ts', ` | ||
require('zone.js/testing'); | ||
require('zone.js/dist/zone-testing'); | ||
require("zone.js/dist/zone-testing"); | ||
// require("zone.js/dist/zone-testing"); | ||
`); | ||
|
||
const newTree = await schematicRunner.runSchematicAsync(schematicName, {}, tree).toPromise(); | ||
expect(newTree.readContent('file.ts')).toBe(` | ||
require('zone.js/testing'); | ||
require('zone.js/testing'); | ||
require("zone.js/testing"); | ||
// require("zone.js/testing"); | ||
`); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters