Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to use a fork of ng-annotate #40

Merged
merged 1 commit into from
Apr 28, 2017

Conversation

bluetech
Copy link
Contributor

ng-annotate is no longer maintained[1], and hence fails when applied to
source code containing modern JavaScript constructs, like import and
export. In particular, this prevents usage with Webpack's ES6 modules
support (issue #17).

[1] olov/ng-annotate#245

To work around it, allow the user to specify a fork of ng-annotate,
which adds support for new JS syntax.

ng-annotate is no longer maintained[1], and hence fails when applied to
source code containing modern JavaScript constructs, like import and
export. In particular, this prevents usage with Webpack's ES6 modules
support (issue andrey-skl#17).

[1] olov/ng-annotate#245

To work around it, allow the user to specify a fork of ng-annotate,
which adds support for new JS syntax.
@bluetech
Copy link
Contributor Author

I created such a fork here: https://github.com/bluetech/ng-annotate-patched and published it to npm under the name ng-annotate-patched. See the README for the changes I had made.

@bluetech
Copy link
Contributor Author

Regarding the unrelated travis failure, I think the problem is caused by typescript, which for some reason emits its code with \r\n new lines instead of the expected \n.

@andrey-skl
Copy link
Owner

@bluetech Yeah I have researched it recently and it uses different new line symbols on Mac and Linux, so it is known issue and build doesn't pass at the moment.

@andrey-skl andrey-skl merged commit c17489f into andrey-skl:master Apr 28, 2017
@bluetech
Copy link
Contributor Author

bluetech commented Apr 29, 2017

Thank you!

Would you mind publishing a release with this commit? I know you had already made one just the other day - sorry about that. Then I would post instructions in the issue on how to use my fork, if people want to do so; it works fairly well on my codebase with Webpack2 and ES6 modules.

@andrey-skl
Copy link
Owner

@bluetech published as 0.6.0 – you're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants