Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(vite-plugin-angular): emit both CJS and ESM formats #582

Closed
wants to merge 1 commit into from
Closed

build(vite-plugin-angular): emit both CJS and ESM formats #582

wants to merge 1 commit into from

Conversation

arturovt
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 51a11b0
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/64c7cb6a6e74d50008afea9c
😎 Deploy Preview https://deploy-preview-582--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 51a11b0
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/64c7cb6a6e74d50008afea9a
😎 Deploy Preview https://deploy-preview-582--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 51a11b0
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/64c7cb6a227853000821cba6
😎 Deploy Preview https://deploy-preview-582--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts
Copy link
Member

Thanks @arturovt. I don't think you need to spin anymore cycles on this at the moment. We may end up just using async imports where needed to make this work in an ESM environment for now.

@benmccann
Copy link

I think you could convert vite-plugin-angular and vite-plugin-nitro to ESM only and leave the Nx plugin as CJS only. Is there any reason to dual publish this package? Vite works just fine with ESM plugins, so you really shouldn't need to provide a CJS plugin. Especially since user code is compiled to ESM for both the client-side and SSR. It seems like it just adds more complication and maintenance burden to keep CJS here and will eventually cause another migration to ESM only, so you might as well just go straight to the end state and be done with dealing with CJS in these packages for good

@brandonroberts
Copy link
Member

Closing in favor of #598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants