Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about AMP being disabled for post type should be hidden for non-admins #4593

Closed
westonruter opened this issue Apr 16, 2020 · 1 comment · Fixed by #5010
Closed

Warning about AMP being disabled for post type should be hidden for non-admins #4593

westonruter opened this issue Apr 16, 2020 · 1 comment · Fixed by #5010
Labels
Changelogged Whether the issue/PR has been added to release notes. Groomed WS:UX Work stream for UX/Front-end
Milestone

Comments

@westonruter
Copy link
Member

Bug Description

Originally reported in #2692. When AMP is not enabled for a post type, there should be no warning displayed users who do not the manage_options capability, since there is no action the user can take. Non-admin users also would likely not care about AMP in the first place.

Relates to #2673.

Expected Behaviour

No warning should be displayed.

Steps to reproduce

  1. Sign-in as a non-admin user.
  2. Disable AMP for a given post type.
  3. Edit an instance of the post type.
  4. See the warning.
  5. Click link and see access denied notice.

Screenshots

Block editor:

image

Classic editor:

image

Clicking link:

image

Additional context

  • WordPress version:
  • Plugin version:
  • Gutenberg plugin version (if applicable):
  • AMP plugin template mode:
  • PHP version:
  • OS:
  • Browser: [e.g. chrome, safari]
  • Device: [e.g. iPhone6]

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter
Copy link
Member Author

QA Passed

When turning off support for the Page post type…

Admin user sees:

Block Editor Classic Editor
image image

Editor user sees:

Block Editor Classic Editor
image image

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 17, 2020
@kmyram kmyram added the WS:UX Work stream for UX/Front-end label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Groomed WS:UX Work stream for UX/Front-end
Projects
None yet
3 participants