Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to update base path mapping #613

Closed
gabmontes opened this issue Jan 23, 2024 · 1 comment · Fixed by #614
Closed

Unable to update base path mapping #613

gabmontes opened this issue Jan 23, 2024 · 1 comment · Fixed by #614
Labels

Comments

@gabmontes
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Bug Report

Error Description
I'm trying to add two API mappings with different base paths to the same API. When doing it the first time, it works. But when one or both mappings already exist, I am getting the error described. So it looks like it is related to the update logic, not the initial creation logic.

Any help hint/will be appreciated. This plugin is super helpful!

Command Run
sls deploy

Console Output

✖ Stack [edited] failed to deploy (460s)
Environment: darwin, node 16.15.0, framework 3.34.0 (local), plugin 6.2.3, SDK 4.3.2
Credentials: Local, environment variables
Docs:        docs.serverless.com
Support:     forum.serverless.com
Bugs:        github.com/serverless/serverless/issues
Error:
Error: V1 - Unable to update base path mapping for '[edited]':
Invalid base path mapping identifier specified
    at APIGatewayV1Wrapper.<anonymous> ([edited]/node_modules/serverless-domain-manager/dist/src/aws/api-gateway-v1-wrapper.js:145:23)
    at Generator.throw (<anonymous>)
    at rejected ([edited]/node_modules/serverless-domain-manager/dist/src/aws/api-gateway-v1-wrapper.js:6:65)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Domain Manager Configuration
Replace this with your own serverless.yml file (anonymized, of course) to help us better resolve your issue.

custom:
  customDomains:
    - rest:
        autoDomain: true
        basePath: path1
        domainName: api.example.com
    - rest:
        autoDomain: true
        basePath: path2
        domainName: api.example.com

Versions

  • Domain Manager version(s): 7.3.3
  • Node/npm version: Node 16.15.0/npm 8.5.5
  • Serverless Version: 3.34.0
  • Lambda Code: Javascript

Possible Solution

Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

@rddimon
Copy link
Collaborator

rddimon commented Jan 30, 2024

Hi @gabmontes

Could you please try the latest version v7.3.4 with allowPathMatching = true for both APIs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants