Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to setup base domain behind HTTP proxy #388

Closed
jamesmbourne opened this issue Sep 22, 2020 · 0 comments · Fixed by #405 or #597
Closed

Unable to setup base domain behind HTTP proxy #388

jamesmbourne opened this issue Sep 22, 2020 · 0 comments · Fixed by #405 or #597
Labels

Comments

@jamesmbourne
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Bug Report

Error Description
Creating a custom domain behind a HTTP proxy fails.

Command Run
sls deploy

Console Output

Error --------------------------------------------------

Error: Error: Unable to setup base domain mappings for (obfuscated)
    at ServerlessCustomDomain.<anonymous> (/app/node_modules/serverless-domain-manager/dist/index.js:164:27)
    at Generator.throw (<anonymous>)
    at rejected (/app/node_modules/serverless-domain-manager/dist/index.js:6:65)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

    For debugging logs, run again after setting the "SLS_DEBUG=*" environment variable.

Domain Manager Configuration
Replace this with your own serverless.yml file (anonymized, of course) to help us better resolve your issue.

customDomain:
  domainName: ${self:custom.vars.domains.${self:provider.stage}}
  basePath: foo
  createRoute53Record: false
  endpointType: regional
  securityPolicy: tls_1_2

Versions

  • Domain Manager version(s): v4.2.3

Possible Solution

Reverting to 4.2.0 resolved the issue. It seems this recent change has changed the CloudFormation provider not to inherit from the Serverless configured AWS SDK.

Serverless Framework is responsible for passing a proxy-agent through to the SDK and configuring this according to the proxy specified in HTTP_PROXY etc. It seems this approach was originally proposed in #86 & implemented in #89.

Additional context/Screenshots
The attempt to make a CloudFormation API call was the only one to fail - all other steps in the deployment succeeded. This aligns with the recent change in #380 to refactor the CloudFormation client.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant