feat: update to use laravel/serializable-closure package
#29
Conversation
owenvoke
force-pushed
the
feature/serializable-closure
branch
from
4c80d11
to
5a294ee
Compare
|
Are there any compatibility concerns or is it fine to release this as v1.1.0? |
|
@kelunik AFAICS this should not introduce any API changes. I would not recommend a patch release still but bumping the minor version looks fine |
|
Yeah, we usually also increase the minor version on PHP version increments I think, independent from the dependency change. |
|
I'll rebase this and resolve the issues mentioned hopefully tomorrow morning. 👍🏻 Cheers. |
owenvoke
force-pushed
the
feature/serializable-closure
branch
from
e7b15f5
to
fec02d6
Compare
owenvoke
force-pushed
the
feature/serializable-closure
branch
from
fec02d6
to
10216d9
Compare
|
@kelunik / @theofidry, that should now all be sorted. 🥳 Let me know if there's anything else required. 👍🏻 |
|
Thanks! I really like how focused the PR is now. 😊 |
|
Yeah, much nicer to have each component update in separate PRs. 👍🏻 |
|
On a side note @kelunik, it looks like Travis CI is no longer running on the repository. Would you be interested in me opening a PR to migrate to GitHub Actions? Or, if not, I guess it might be worth re-enabling Travis CI. 👍🏻 |
|
I know, already thought about asking you to update that as well, but just did it myself. 😄 |
|
I've tagged v1.1.0 now. 🎉 |
|
Thanks a lot! |
|
Thank you! |
This allows supporting PHP 8.1, and is required for us to continue using this package with Box, as 4.x of
opis/closurerequires FFI, which afaik isn't wanted for Box. Happy to make any changes if required. 👍🏻It looks like Travis doesn't yet support PHP
8.1(unless it's hardcoded to8.1.0) 🤷🏻Also, looks like the quotes were changed in error messages as part of PHP 8.0 (see php/php-src#5590), so I've updated the
testUnserializableClassStaticMethod()test to cover this.