Fix preference methods returning all the preferences #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling the method `user_preference` was returning all the user preferences by invoking the action `user_preferences` instead of invoking the action matching the method name and returning only the requested preference. Similarly, the method `system_preference` was invoking the action `system_preferences`.
The parameter `filter_str` is not optional on the methods `user_preference` and `system_preference`.
|
that's one annoying thing about plurals |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix what appears to be a copy-paste error:
Calling the method
user_preferencewas returning all the user preferences by invoking the actionuser_preferencesinstead of invoking the action matching the method name and returning only the requested preference.Similarly, the method
system_preferencewas invoking the actionsystem_preferences.