Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from ant-design:master #225

Closed
wants to merge 124 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Nov 14, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

zombieJ and others added 30 commits October 10, 2023 16:22
* docs: init

* chore: update example

* test: update test

* docs: update doc

* chore: fix lint

* chore: update limit
* feat: add ref

* feat: table support reference

* chore: rename

* chore: proxy

* test: add test case

* chore: fix lint

* docs: update desc

* docs: update desc

* docs: update desc

* chore: clean up

* chore: fix lint
chore: feature merge master
* feat: App support component

* test: update test case

* chore: update ts
* docs: init

* feat: support inherit

* test: update snapshot
* chore: bump rc-input-number

* test: update test case
* chore: bump rc-tabs

* chore: update limit

* chore: fix lint
chore: feature merge master
* fix: dropdown not trigger onOpenChange when click menu item

* chore: add source

* docs: update

* test: update test
* feat: start the implementation of the fullscreen prop in Spin

* docs: change main spin demo

* docs: enhance demo

* test: update snapshot

* fix: address pr comments

* fix: use logical property on fullscreen class

* fix: address pr review

* feat: Added background color token

* fix: remove onClick and change demo

* feat: change spin to white when fullcreen

also use the bgmask as background, removing the bgColor token

* fix: unused import

* test: update snapshot

* Update components/spin/style/index.tsx

Signed-off-by: lijianan <574980606@qq.com>

* fix: use white color from token

* fix: not needed interpolation and version

* fix: address pr review

* fix: tip prop was not working

* test: cover tip & fullscreen case

* fix: addrress pr coments

---------

Signed-off-by: lijianan <574980606@qq.com>
Co-authored-by: lijianan <574980606@qq.com>
Co-authored-by: MadCcc <1075746765@qq.com>
* feat: z-index manager

* feat: z-index manager

* feat: update snap

* chore: update site-limit

* feat: optimize code

* feat: optimize code

* feat: add test case

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code

* feat: optimize code
chore: merge master into feature
* feat: Popconfirm support z-index manager

* Update components/popconfirm/__tests__/index.test.tsx

Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

---------

Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
* feat: Popover support z-index manager

* feat: update snap

* Update components/popover/__tests__/index.test.tsx

Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>

---------

Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
* feat: Tooltip support z-index manager

* feat: optimize code
Zaynex and others added 15 commits November 10, 2023 09:53
* chore: header use d2tech

* chore: del img

* chore: use d2 head background

* Apply suggestions from code review

style: keep message unified style

Co-authored-by: afc163 <afc163@gmail.com>
Signed-off-by: Vincent <Zaynex@126.com>

---------

Signed-off-by: Vincent <Zaynex@126.com>
Co-authored-by: xiwenzheng.xwz <xiwenzheng.xwz@antgroup.com>
Co-authored-by: afc163 <afc163@gmail.com>
* docs: Update CHANGELOG of 5.11.1

Signed-off-by: afc163 <afc163@gmail.com>

* Update CHANGELOG.en-US.md

Signed-off-by: afc163 <afc163@gmail.com>

---------

Signed-off-by: afc163 <afc163@gmail.com>
Signed-off-by: afc163 <afc163@gmail.com>
(cherry picked from commit b21741d)
Bumps [tsx](https://github.com/privatenumber/tsx) from 3.14.0 to 4.1.0.
- [Release notes](https://github.com/privatenumber/tsx/releases)
- [Changelog](https://github.com/privatenumber/tsx/blob/develop/release.config.cjs)
- [Commits](privatenumber/tsx@v3.14.0...v4.1.0)

---
updated-dependencies:
- dependency-name: tsx
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* docs: update Next.js docs

* Update use-with-next.en-US.md

Signed-off-by: lijianan <574980606@qq.com>

* Update use-with-next.zh-CN.md

Signed-off-by: lijianan <574980606@qq.com>

---------

Signed-off-by: lijianan <574980606@qq.com>
Signed-off-by: afc163 <afc163@gmail.com>
* feat: support popupBg and darkPopupBg

* fix test
* fix: QRCode style.padding should work

* refactor qrcode padding and size

* chore: fix test cases

* refactor: revert qrcode size

* refactor: remove !important

* chore: fix test case
Co-authored-by: afc163 <afc163@users.noreply.github.com>
Copy link

Review changes with SemanticDiff

Copy link

restack-app bot commented Nov 14, 2023

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

Copy link

coderabbitai bot commented Nov 14, 2023

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

commit-lint bot commented Nov 14, 2023

Features

Bug Fixes

Chore

Contributors

zombieJ, li-jia-nan, kiner-tang, Rafael-Martins, github-actions[bot]

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

Copy link

pr-code-reviewer bot commented Nov 14, 2023

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

Copy link

instapr bot commented Nov 14, 2023

Nice work on the changes! Just a couple of comments:

  • file1.py: Consider using a more descriptive variable name on line 30.
  • file2.py: Avoid using magic numbers on line 42.

Other than that, the code looks good. Well done! 👍

Copy link

Hi @pull[bot]. Thanks for your contribution. But, we don't have plan to add README of more languages. This current PR will be closed and team members will help on this.

Copy link

Hi @pull[bot]. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

Copy link

Prepare preview

@github-actions github-actions bot closed this Nov 14, 2023
Copy link

Hi @pull[bot]。

请注意,当前 PR 是分支间的互相合并,请使用 BranchAutoMerge 标签来进行自动合并。切记不要、不要、不要使用 Squash

@github-actions github-actions bot closed this Nov 14, 2023
@pull pull bot added the ⤵️ pull label Nov 14, 2023
Copy link

sweep-ai bot commented Nov 14, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

Pull Request Review Markdown Document

Hey there! 👋 Here's a summary of the previous results for the pull request review. Let's dive in!

Changes:

  1. Major changes:
    • Updated the node version in .codesandbox/ci.json from 14 to 18.
    • Updated properties in the cn object in .dumi/theme/slots/Header/index.tsx.
    • Updated values in the token object in .dumi/theme/slots/Header/index.tsx.
    • Added the lodash plugin to the plugins array in .eslintrc.js.

Suggestions:

  1. Suggestions to improve code:
    • In .dumi/theme/common/LiveCode.tsx, consider using box-shadow instead of border for the :hover and :focus styles to create a more visually appealing effect.

Bugs:

  1. Potential bugs:
    • In .dumi/theme/slots/Header/index.tsx, the link property in the cn object is missing a closing quote.

Improvements:

  1. Places to refactor for better readability:
    • In .dumi/theme/slots/Header/index.tsx, consider removing the img element with the styles.icon class as it is not being used.

Rating:

  • Code rating: 7/10
  • Criteria:
    • Readability: The code is generally readable.
    • Performance: No specific rating provided.
    • Security: No specific rating provided.

That's it for the summary! Feel free to check out the detailed results above. If you have any questions or need further assistance, feel free to ask. Happy coding! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.