Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The OP code is currently a string and should be binary numbers. Also the size of RRQ and WRQ looks wrong. #1

Open
satiros12 opened this issue Apr 27, 2017 · 1 comment

Comments

@satiros12
Copy link

RRQ and WRQ should have 4+file_name_size + mode_name_size bytes. Because first 2 are for OP code and the other 2 are zero bytes between the file name and after the mode name.

@jrrk
Copy link

jrrk commented Feb 13, 2019

Likewise, strings containing \000 bytes cannot be used because the string terminates at this point, and in addition when using malloc() the size to be allocated needs one added when any of the str... functions are used due to 0 termination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants