Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): update to work with node 14 #17

Merged
merged 4 commits into from
May 22, 2020
Merged

feat(node): update to work with node 14 #17

merged 4 commits into from
May 22, 2020

Conversation

JamesSingleton
Copy link
Contributor

Fixes #16

@JamesSingleton JamesSingleton requested a review from a team as a code owner May 22, 2020 00:04
PixnBits
PixnBits requested changes May 22, 2020
View reviewed changes
Copy link
Contributor

@PixnBits PixnBits left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!
[edit]
I think it looks like Travis ran the tests on Node.JS 10.x but not 12.x or 14.x, should .travis.yml be updated to run the tests on multiple Node versions?

html-report-creator.js Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@JamesSingleton
Copy link
Contributor Author

@PixnBits actually 8f647c3 fixes the travis config.

@JamesSingleton JamesSingleton merged commit ad8663a into americanexpress:master May 22, 2020
oneamexbot added a commit that referenced this pull request May 26, 2020
@oneamexbot
chore(release): 6.1.0 [skip ci]
eb7c44e 
# [6.1.0](v6.0.1...v6.1.0) (2020-05-26)

### Features

* **node:** update to work with node 14 ([#17](#17)) ([ad8663a](ad8663a)), closes [#16](#16)
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@10xLaCroixDrinker 10xLaCroixDrinker 10xLaCroixDrinker approved these changes

@PixnBits PixnBits PixnBits approved these changes

@Francois-Esquire Francois-Esquire Francois-Esquire left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to write HTML report in Node.JS 14.x
5 participants
@JamesSingleton @oneamexbot @10xLaCroixDrinker @PixnBits @Francois-Esquire