Add ament_generate_version_header #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a CMake macro that gives more control over the install path and integrates with modern CMake targets. Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
|
CI (build:
|
|
Is there a pull request updating at least one place that this is used? Like in |
@wjwwood I opened one: ros2/rclcpp#1886 I'll re-run CI with it |
|
CI re-run
|
|
Should we deprecate the old style? |
wjwwood
approved these changes
Feb 14, 2022
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
Yeah, I think so. Added a deprecation to |
wjwwood
approved these changes
Feb 14, 2022
|
CI re-run
|
delete-merged-branch
bot
deleted the
sloretz__ament_generate_version_header
branch
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CMake macro that gives more control over the install path and integrates with modern CMake targets.
Part of ros2/ros2#1150 - this makes it easy for a package to control where the header is installed, and by-default installs it to an extra
${PROJECT_NAME}folder to avoid include directory search order issues when overriding packages from merged workspaces.