fix(cuboid_transformer): Modified the argument order of '_generalize_padding' so that 'pad_h' comes before 'pad_w'. #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
In Line 280 of the PatchMerging3D class, the order of the pad_h and pad_w arguments in _generalize_padding is incorrect.
AS-IS: x = _generalize_padding(x, pad_t, pad_w, pad_h, padding_type=self.padding_type)
TO-BE: x = _generalize_padding(x, pad_t, pad_h, pad_w, padding_type=self.padding_type)
Description of changes:
The order of arguments in '_generalize_padding' has been modified so that pad_h comes before pad_w.
--
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.