Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace timeout by link and customize chunks #1

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

amaralc
Copy link
Owner

@amaralc amaralc commented Aug 29, 2024

What and why was modified?

  • Chunk file name and path outputs were customized using rollulpOptions to prevent errors when files are updated;
  • Replaced delay by link to try to reproduce and fix the issue TypeError: Failed to fetch dynamically imported module vitejs/vite#11804 for the following use case:
    • WHEN user loads initial page before a new deployment is made;
    • AND a new deployment removes a dynamically imported module that was referenced in the previous deployment;
    • AND user clicks a link that is available in his stale version;
    • THEN user experiences an error TypeError: Failed to fetch dynamically imported module;

@amaralc amaralc merged commit 628d723 into master Aug 29, 2024
@amaralc
Copy link
Owner Author

amaralc commented Aug 29, 2024

Suspense was missing in this implementation and added later in 36f5080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant