Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving from dagger-1 to dagger-2 #597

Open
cpg opened this issue Aug 4, 2020 · 5 comments
Open

Moving from dagger-1 to dagger-2 #597

cpg opened this issue Aug 4, 2020 · 5 comments
Assignees
@cpg
Labels
help wanted

Comments

@cpg
Copy link
Member

cpg commented Aug 4, 2020

Describe the issue
Dagger-2 has been released and we should move to it
@cpg cpg self-assigned this Aug 4, 2020
@chirag-jn chirag-jn mentioned this issue Aug 8, 2020
Merged
4 tasks
@chirag-jn
Copy link
Member

Once this issue is resolved, we can easily start solving #540

@chirag-jn chirag-jn mentioned this issue Aug 11, 2020
Open
@chirag-jn chirag-jn mentioned this issue Sep 8, 2020
Merged
@chirag-jn
Copy link
Member

After moving to Dagger 2, change the play-services-cast-framework library version used too. For discussions, refer #671

@FareesHussain
Copy link

Switching to Hilt would be better than dagger 2 right?!

@chirag-jn
Copy link
Member

Switching to Hilt would be better than dagger 2 right?!

Hilt seems to be built above Dagger 2 only. If you can go ahead and work on it, it would be nice!

@Prakhar-Agarwal-byte
Copy link
Contributor

Prakhar-Agarwal-byte commented Mar 5, 2021 •
edited
Loading

Switching to Hilt would be better than dagger 2 right?!

Hilt seems to be built above Dagger 2 only. If you can go ahead and work on it, it would be nice!

Hilt is still in alpha and we should take caution in using it in production (my opinion). What I think is first we should move to Dagger 2 then later we can add Hilt as it is based on Dagger only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpg cpg

Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cpg @Prakhar-Agarwal-byte @chirag-jn @FareesHussain