Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VolumetricRend: Fix lots of stuff #7

Merged
merged 1 commit into from
Dec 22, 2023
Merged

VolumetricRend: Fix lots of stuff #7

merged 1 commit into from
Dec 22, 2023

Conversation

fredroy
Copy link

@fredroy fredroy commented Dec 22, 2023

  • pushing zero array in gl (skipped in release mode 😅)
  • calling gl functions not in context (qt gui was spared because it is always in a gl context, whereas glfw is not 😅)
  • fix for intel gpu

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger merged commit 3068183 into alxbilger:volrender Dec 22, 2023
2 checks passed
bakpaul pushed a commit that referenced this pull request Jan 5, 2024
@alxbilger @fredroy @hugtalbot
[VolumetricRendering] Fix the compilation (sofa-framework#4398)
9a107f7 
* [VolumetricRendering] Fix the compilation

But scenes crash

* reflect changes from datatype change for vec3state (#6)

* fix lots of stuff (#7)

---------

Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>
Co-authored-by: Hugo <hugo.talbot@sofa-framework.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxbilger alxbilger alxbilger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredroy @alxbilger