Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update start docs description to correctly say using the fraud dataset #2370

Merged
merged 5 commits into from
Jun 15, 2021
Merged

Update start docs description to correctly say using the fraud dataset #2370

merged 5 commits into from
Jun 15, 2021

Conversation

angela97lin
Copy link
Contributor

Closes #2335

@angela97lin angela97lin self-assigned this Jun 10, 2021
@codecov
Copy link

codecov bot commented Jun 10, 2021 •
edited
Loading

Codecov Report

Merging #2370 (7e23e06) into main (ca576c1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2370   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        281     281           
  Lines      24926   24926           
=====================================
  Hits       24829   24829           
  Misses        97      97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca576c1...7e23e06. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review June 11, 2021 14:53
freddyaboulton
freddyaboulton approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @angela97lin !

jeremyliweishih
jeremyliweishih approved these changes Jun 11, 2021
View reviewed changes
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

bchen1116
bchen1116 approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@chukarsten chukarsten merged commit ad921c4 into main Jun 15, 2021
@chukarsten chukarsten deleted the 2335_docs branch June 15, 2021 22:23
@chukarsten chukarsten mentioned this pull request Jun 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

@bchen1116 bchen1116 bchen1116 approved these changes

@freddyaboulton freddyaboulton freddyaboulton approved these changes

@chukarsten chukarsten chukarsten approved these changes

@dsherry dsherry Awaiting requested review from dsherry

@ParthivNaresh ParthivNaresh Awaiting requested review from ParthivNaresh

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start page has a mismatch between the dataset used in code and the description.
5 participants
@angela97lin @jeremyliweishih @bchen1116 @freddyaboulton @chukarsten