Update body classes for govuk frontend v5 #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the
<script>
snippet in the test templates.Why
For govuk-frontend v5, there now needs to be additional class added to the
body
tag to indicate that the components are supported.This class is
govuk-frontend-supported
and is added if the browser supports JS of typemodule
(which is the new browser target for govuk-frontend).The script tag is directly taken from the documentation, see "Update the
<script>
snippet at the top of your<body>
tag" in the release notes for govuk-frontend 5.0.0We can safely move to the new snippet in advance of upgrading to V5 of govuk-frontend and ensure components from govuk-frontend still initialise as expect when running integration tests from apps such as smart-answers.
Trello card