Tidy up post feature removal

- Remove leftover `similar_search_results` views - Remove `ElasticSearchRecommendedLink` model - Remove `ElasticSearchBetIdGenerator` generator - Remove leftover Cucumber step definitions and support code - Remove one-off Rake task - Remove `cucumber` script and `scripts/` directory (this is run through Rake anyway) - Remove `BetParamsParser` and `DateParser` - Remove `BetDateValidator` and `BetLinkValidator` - Remove unneeded Search API initializer and service definition - Remove unneeded Zeitwerk inflection configuration initializer - Remove unused Cucumber step definitions - Remove cookie rotation code - Remove unneeded Sidekiq scheduler configuration file
alphagov · Apr 15, 2024 · 8d8a372 · 8d8a372
1 parent a6a93f8
commit 8d8a372
Show file tree

Hide file tree

Showing 23 changed files with 0 additions and 613 deletions.
diff --git a/app/generators/elastic_search_bet_id_generator.rb b/app/generators/elastic_search_bet_id_generator.rb
diff --git a/app/lib/services.rb b/app/lib/services.rb
@@ -8,14 +8,4 @@ def self.publishing_api
       bearer_token: ENV["PUBLISHING_API_BEARER_TOKEN"] || "example",
     )
   end
-
-  # TODO: update RUMMAGER_BEARER_TOKEN to SEARCH_API_BEARER_TOKEN
-  def self.search_api
-    @search_api ||=
-      GdsApi::Search.new(
-        Plek.find("search-api"),
-        api_version: "V2",
-        bearer_token: ENV["RUMMAGER_BEARER_TOKEN"] || "example",
-      )
-  end
 end
diff --git a/app/models/elastic_search_recommended_link.rb b/app/models/elastic_search_recommended_link.rb
diff --git a/app/parsers/bet_params_parser.rb b/app/parsers/bet_params_parser.rb
diff --git a/app/parsers/date_parser.rb b/app/parsers/date_parser.rb
diff --git a/app/validators/bet_date_validator.rb b/app/validators/bet_date_validator.rb
diff --git a/app/validators/bet_link_validator.rb b/app/validators/bet_link_validator.rb
diff --git a/app/views/similar_search_results/_form.html.erb b/app/views/similar_search_results/_form.html.erb
diff --git a/app/views/similar_search_results/_results.html.erb b/app/views/similar_search_results/_results.html.erb
diff --git a/app/views/similar_search_results/new.html.erb b/app/views/similar_search_results/new.html.erb
diff --git a/app/views/similar_search_results/show.html.erb b/app/views/similar_search_results/show.html.erb
diff --git a/config/application.rb b/config/application.rb
@@ -58,22 +58,5 @@ class Application < Rails::Application
 
     # Require `belongs_to` associations by default. Previous versions had false.
     config.active_record.belongs_to_required_by_default = false
-
-    # Rotate SHA1 cookies to SHA256 (the new Rails 7 default)
-    # TODO: Remove this after existing user sessions have been rotated
-    # https://guides.rubyonrails.org/v7.0/upgrading_ruby_on_rails.html#key-generator-digest-class-changing-to-use-sha256
-    Rails.application.config.action_dispatch.cookies_rotations.tap do |cookies|
-      salt = Rails.application.config.action_dispatch.authenticated_encrypted_cookie_salt
-      secret_key_base = Rails.application.secrets.secret_key_base
-      next if secret_key_base.blank?
-
-      key_generator = ActiveSupport::KeyGenerator.new(
-        secret_key_base, iterations: 1000, hash_digest_class: OpenSSL::Digest::SHA1
-      )
-      key_len = ActiveSupport::MessageEncryptor.key_len
-      secret = key_generator.generate_key(salt, key_len)
-
-      cookies.rotate :encrypted, secret
-    end
   end
 end
diff --git a/config/initializers/services_and_listeners.rb b/config/initializers/services_and_listeners.rb
diff --git a/config/initializers/zeitwerk.rb b/config/initializers/zeitwerk.rb
diff --git a/config/sidekiq.yml b/config/sidekiq.yml
diff --git a/features/step_definitions/query_steps.rb b/features/step_definitions/query_steps.rb