Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document list: Add option for equal item spacing #4293

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

csutter
Copy link
Contributor

@csutter csutter commented Oct 8, 2024

What

The items in a document list currently have slightly more padding above the separator than below. This adds an option to have equal spacing on both sides.

Why

For the new design for GOV.UK Search, we want the spacing above and below the separator to be equal.

Visual Changes

Before

image

After

image

The items in a document list currently have slightly more padding above
the separator than below. For the new design for GOV.UK Search, we want
the spacing above and below the separator to be equal.
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4293 October 8, 2024 15:58 Inactive
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, nice work 👍

@csutter csutter merged commit 25b72c4 into main Oct 9, 2024
12 checks passed
@csutter csutter deleted the doclist-padding branch October 9, 2024 11:23
@MartinJJones MartinJJones mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants