Standardise inverse option for action link component #4288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
changed the title
andysellick
force-pushed
the
standardise-inverse
branch
from
7445c4f
to
31de9d4
Compare
andysellick
force-pushed
the
standardise-inverse
branch
from
31de9d4
to
6aab99b
Compare
- renames option from 'light_text' to 'inverse'
andysellick
force-pushed
the
standardise-inverse
branch
from
6aab99b
to
9e29059
Compare
richardTowers
approved these changes
Oct 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rename action link component option for displaying it on a dark background from
light_texttoinverse.This could potentially be a breaking change but I've checked and I don't think this option is currently in use anywhere. The places the action link component is used are:
frontendon the homepage (on a white background https://www.gov.uk/)collectionsin the browse pages (on a white background https://www.gov.uk/browse/benefits)Why
We're doing some unrelated work with the action link component and the fact that action link uses something other than
inversecauses extra code to be required. Most of our components with an inverse option useinverseso it seems like standardising is sensible as well.Visual Changes
Should be no actual visual changes apart from some of the names of the examples in the component guide.