removed unused cookies in cookie category #4234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
approved these changes
Sep 18, 2024
sairamya93
force-pushed
the
remove-unused-cookie-category
branch
from
ecbdb92
to
79ac721
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
To remove 'govuk_not_first_visit' and 'govuk_browser_upgrade_dismissed'
Why
These are no longer being used and we don’t actually present a banner of this nature any more. We should remove references to it from the govuk_publishing_components gem
https://trello.com/c/lR7DOoLn/341-we-refer-to-cookies-that-are-no-longer-in-use
Visual Changes
Ensure that references to it are removed from Details about cookies on GOV.UK