Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sortable table header issue on mobile #4233

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

jon-kirwan
Copy link
Contributor

@jon-kirwan jon-kirwan commented Sep 18, 2024

What

Fix sortable table header issue on mobile

Why

The icon overlays the text when space is limited.

Visual Changes

Before (mobile)

After (mobile)

Before (>= tablet)

components publishing service gov uk_component-guide_table_with_sortable_head_preview(iPad Pro)

After (>= tablet, no change)

govuk-publishing-components dev gov uk_component-guide_table_with_sortable_head_preview(iPad Pro)

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4233 September 18, 2024 12:31 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4233 September 18, 2024 12:39 Inactive
@jon-kirwan jon-kirwan force-pushed the fix-sortable-table-header-issue-on-mobile branch from e727f4d to adf0caa Compare September 18, 2024 14:23
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4233 September 18, 2024 14:23 Inactive
@jon-kirwan jon-kirwan force-pushed the fix-sortable-table-header-issue-on-mobile branch from adf0caa to 943eb58 Compare September 18, 2024 15:04
@jon-kirwan jon-kirwan marked this pull request as ready for review September 18, 2024 15:05
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4233 September 18, 2024 15:05 Inactive
@jon-kirwan jon-kirwan force-pushed the fix-sortable-table-header-issue-on-mobile branch from 943eb58 to 19d43dd Compare September 19, 2024 08:51
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4233 September 19, 2024 08:52 Inactive
@jon-kirwan jon-kirwan merged commit 725b929 into main Sep 19, 2024
12 checks passed
@jon-kirwan jon-kirwan deleted the fix-sortable-table-header-issue-on-mobile branch September 19, 2024 09:01
@yndajas yndajas mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants