Merge pull request #3553 from alphagov/ga4-attachment-link-fix

Ensure file attachments have the GA4 event_name 'file_download'

CHANGELOG.md

@@ -10,6 +10,7 @@
 ## Unreleased
 
 * Add GA4 tracking to the emergency banner ([PR #3549](https://github.com/alphagov/govuk_publishing_components/pull/3549))
+* Ensure file attachments have the GA4 event_name 'file_download' ([PR #3553](https://github.com/alphagov/govuk_publishing_components/pull/3553))
 
 ## 35.13.2
 

app/views/govuk_publishing_components/components/_attachment.html.erb

@@ -11,6 +11,7 @@
 
   container_class_names = %w[gem-c-attachment govuk-!-display-none-print]
   container_class_names << shared_helper.get_margin_bottom if local_assigns.key?(:margin_bottom)
+  ga4_link = { 'event_name': 'navigation', 'type': 'attachment' }
 
   case attachment.type
   when "file"
@@ -38,6 +39,9 @@
         class: "gem-c-attachment__attribute",
       )
     end
+
+    ga4_link[:event_name] = 'file_download'
+
   when "html"
     attributes << tag.span(
       "HTML",
@@ -51,7 +55,7 @@
   end
 
 %>
-<%= tag.section class: class_names(container_class_names), data: { module: "ga4-link-tracker", ga4_track_links_only: "", ga4_link: { 'event_name': 'navigation', 'type': 'attachment' } } do %>
+<%= tag.section class: class_names(container_class_names), data: { module: "ga4-link-tracker", ga4_track_links_only: "", ga4_link: ga4_link } do %>
   <%= tag.div class: "gem-c-attachment__thumbnail" do %>
     <%= link_to attachment.url,
                 class: "govuk-link",

spec/components/attachment_spec.rb

@@ -269,7 +269,7 @@ def assert_thumbnail(type, src: nil)
     assert_select '.gem-c-attachment:not([class*="govuk-!-margin-bottom-"])'
   end
 
-  it "includes GA4 tracking on attachment links by default" do
+  it "includes GA4 tracking on HTML attachment links by default" do
     render_component(
       attachment: {
         title: "Test",
@@ -283,4 +283,19 @@ def assert_thumbnail(type, src: nil)
     assert_select "section[data-ga4-link='{\"event_name\":\"navigation\",\"type\":\"attachment\"}']"
     assert_select "section[data-ga4-track-links-only]"
   end
+
+  it "includes GA4 tracking on file attachment links by default" do
+    render_component(
+      attachment: {
+        title: "Test",
+        url: "https://example.com",
+        filename: "test",
+        content_type: "application/pdf",
+      },
+    )
+
+    assert_select "section[data-module=ga4-link-tracker]"
+    assert_select "section[data-ga4-link='{\"event_name\":\"file_download\",\"type\":\"attachment\"}']"
+    assert_select "section[data-ga4-track-links-only]"
+  end
 end