Merge pull request #3918 from alphagov/remove-popular-from-super-nav

Remove "Popular" links from super navigation header
alphagov · Mar 15, 2024 · 404eea0 · 404eea0
2 parents 4a17fd0 + 24595b3
commit 404eea0
Show file tree

Hide file tree

Showing 69 changed files with 7 additions and 243 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@
 ## 37.8.0
 
 * Disable the single consent cookie API code ([PR #3916](https://github.com/alphagov/govuk_publishing_components/pull/3916))
+* Remove "Popular" links from super navigation header ([PR #3918](https://github.com/alphagov/govuk_publishing_components/pull/3918))
 
 ## 37.7.1
 

diff --git a/...s/stylesheets/govuk_publishing_components/components/_layout-super-navigation-header.scss b/...s/stylesheets/govuk_publishing_components/components/_layout-super-navigation-header.scss
@@ -884,7 +884,11 @@ $after-button-padding-left: govuk-spacing(4);
 }
 
 .gem-c-layout-super-navigation-header__search-form {
-  padding: 0 0 govuk-spacing(8) 0;
+  padding: 0;
+
+  @include govuk-media-query($from: "desktop") {
+    padding-bottom: govuk-spacing(2);
+  }
 }
 
 // Popular links.
@@ -893,17 +897,6 @@ $after-button-padding-left: govuk-spacing(4);
   padding: govuk-spacing(1) 0;
 }
 
-.gem-c-layout-super-navigation-header__popular-link {
-  display: inline-block;
-  font-size: 16px;
-  font-size: govuk-px-to-rem(16px);
-  padding: 0;
-
-  &::after {
-    @include make-selectable-area-bigger;
-  }
-}
-
 .gem-c-layout-super-navigation-header__width-container {
   @include govuk-media-query($until: "desktop") {
     margin: 0;
@@ -988,11 +981,6 @@ $after-button-padding-left: govuk-spacing(4);
 }
 
 @include govuk-media-query($until: tablet) {
-  .gem-c-layout-super-navigation-header__popular-links-heading--large-navbar {
-    font-size: 24px;
-    font-size: govuk-px-to-rem(24px);
-  }
-
   // can't disable responsive styling because using override classes
   // from govuk-frontend which are all responsive so have to supply
   // custom class to the label of the search component to turn off

diff --git a/app/views/govuk_publishing_components/components/_layout_super_navigation_header.html.erb b/app/views/govuk_publishing_components/components/_layout_super_navigation_header.html.erb
@@ -15,8 +15,6 @@
   navigation_menu_heading = t("components.layout_super_navigation_header.navigation_menu_heading")
   navigation_search_heading = t("components.layout_super_navigation_header.navigation_search_heading")
   navigation_search_subheading = t("components.layout_super_navigation_header.navigation_search_subheading")
-  popular_links = t("components.layout_super_navigation_header.popular_links")
-  popular_links_heading = t("components.layout_super_navigation_header.popular_links_heading")
   search_text = t("components.layout_super_navigation_header.search_text")
 
   hide_search_menu_text = t("components.layout_super_navigation_header.menu_toggle_label.hide", :label => "search")
@@ -68,9 +66,6 @@
   dropdown_menu_classes = %w(gem-c-layout-super-navigation-header__navigation-dropdown-menu)
   dropdown_menu_classes << "gem-c-layout-super-navigation-header__navigation-dropdown-menu--large-navbar" if large_navbar
 
-  popular_links_heading_classes = %w(govuk-heading-m)
-  popular_links_heading_classes << "gem-c-layout-super-navigation-header__popular-links-heading--large-navbar" if large_navbar
-
   absolute_links_helper = GovukPublishingComponents::Presenters::AbsoluteLinksHelper.new()
 %>
 <%= content_tag("header",
@@ -385,45 +380,6 @@
               </form>
             </div>
           </div>
-          <div class="govuk-grid-row">
-            <div class="govuk-grid-column-full">
-              <%= content_tag(:h3, {
-                class: popular_links_heading_classes
-              }) do %>
-                <%= popular_links_heading %>
-              <% end %>
-              <ul class="govuk-list">
-                <% index_total = popular_links.length %>
-                <% popular_links.each_with_index do | popular_link, index | %>
-                  <li class="gem-c-layout-super-navigation-header__popular-item">
-                    <% link_href = absolute_links_helper.make_url_absolute(popular_link[:href]) %>
-                    <%= link_to popular_link[:label], link_href, {
-                      class: [
-                        "govuk-link",
-                        "gem-c-layout-super-navigation-header__popular-link",
-                      ],
-                      data: {
-                        track_action: "popularLink",
-                        track_category: "headerClicked",
-                        track_label: popular_link[:href],
-                        track_dimension: popular_link[:label],
-                        track_dimension_index: "29",
-                        ga4_link: {
-                          "event_name": "navigation",
-                          "type": "header menu bar",
-                          "index_section": 4,
-                          "index_link": index + 1,
-                          "index_section_count": 4,
-                          "index_total": index_total,
-                          "section": popular_links_heading,
-                        }
-                      }
-                    } %>
-                  </li>
-                <% end %>
-              </ul>
-            </div>
-          </div>
         </div>
       <% end %>
     </nav>

diff --git a/config/locales/ar.yml b/config/locales/ar.yml
@@ -127,8 +127,6 @@ ar:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: من

diff --git a/config/locales/az.yml b/config/locales/az.yml
@@ -124,8 +124,6 @@ az:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: "...dan (dən)"

diff --git a/config/locales/be.yml b/config/locales/be.yml
@@ -130,8 +130,6 @@ be:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: З

diff --git a/config/locales/bg.yml b/config/locales/bg.yml
@@ -128,8 +128,6 @@ bg:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: От

diff --git a/config/locales/bn.yml b/config/locales/bn.yml
@@ -125,8 +125,6 @@ bn:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: থেকে

diff --git a/config/locales/cs.yml b/config/locales/cs.yml
@@ -129,8 +129,6 @@ cs:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: 'Komu I:'

diff --git a/config/locales/cy.yml b/config/locales/cy.yml
@@ -128,8 +128,6 @@ cy:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: Gan

diff --git a/config/locales/da.yml b/config/locales/da.yml
@@ -125,8 +125,6 @@ da:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: Fra

diff --git a/config/locales/de.yml b/config/locales/de.yml
@@ -128,8 +128,6 @@ de:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: Von

diff --git a/config/locales/dr.yml b/config/locales/dr.yml
@@ -126,8 +126,6 @@ dr:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: از

diff --git a/config/locales/el.yml b/config/locales/el.yml
@@ -124,8 +124,6 @@ el:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: Από

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -231,20 +231,6 @@ en:
       navigation_menu_heading: Navigation menu
       navigation_search_heading: Search and popular pages
       navigation_search_subheading: Search
-      popular_links:
-      - label: Get support with the cost of living
-        href: "/cost-of-living"
-      - label: Find out about help you can get with your energy bills
-        href: "/get-help-energy-bills"
-      - label: Find a job
-        href: "/find-a-job"
-      - label: 'Universal Credit account: sign in'
-        href: "/sign-in-universal-credit"
-      - label: Check your National Insurance record
-        href: "/check-national-insurance-record"
-      - label: 'Check MOT history of a vehicle'
-        href: /check-mot-history
-      popular_links_heading: Popular on GOV.UK
       search_text: Search GOV.UK
     metadata:
       from: From

diff --git a/config/locales/es-419.yml b/config/locales/es-419.yml
@@ -124,8 +124,6 @@ es-419:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: Desde

diff --git a/config/locales/es.yml b/config/locales/es.yml
@@ -124,8 +124,6 @@ es:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: Desde

diff --git a/config/locales/et.yml b/config/locales/et.yml
@@ -127,8 +127,6 @@ et:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: Alates

diff --git a/config/locales/fa.yml b/config/locales/fa.yml
@@ -123,8 +123,6 @@ fa:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: از

diff --git a/config/locales/fi.yml b/config/locales/fi.yml
@@ -126,8 +126,6 @@ fi:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: Alkaen

diff --git a/config/locales/fr.yml b/config/locales/fr.yml
@@ -124,8 +124,6 @@ fr:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: De

diff --git a/config/locales/gd.yml b/config/locales/gd.yml
@@ -126,8 +126,6 @@ gd:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: De

diff --git a/config/locales/gu.yml b/config/locales/gu.yml
@@ -124,8 +124,6 @@ gu:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: થી

diff --git a/config/locales/he.yml b/config/locales/he.yml
@@ -124,8 +124,6 @@ he:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: מ-

diff --git a/config/locales/hi.yml b/config/locales/hi.yml
@@ -124,8 +124,6 @@ hi:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: से

diff --git a/config/locales/hr.yml b/config/locales/hr.yml
@@ -125,8 +125,6 @@ hr:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: Iz

diff --git a/config/locales/hu.yml b/config/locales/hu.yml
@@ -127,8 +127,6 @@ hu:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: Feladó

diff --git a/config/locales/hy.yml b/config/locales/hy.yml
@@ -128,8 +128,6 @@ hy:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: Ումից՝

diff --git a/config/locales/id.yml b/config/locales/id.yml
@@ -124,8 +124,6 @@ id:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: Dari

diff --git a/config/locales/is.yml b/config/locales/is.yml
@@ -124,8 +124,6 @@ is:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: Frá

diff --git a/config/locales/it.yml b/config/locales/it.yml
@@ -124,8 +124,6 @@ it:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: Da

diff --git a/config/locales/ja.yml b/config/locales/ja.yml
@@ -120,8 +120,6 @@ ja:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: から

diff --git a/config/locales/ka.yml b/config/locales/ka.yml
@@ -127,8 +127,6 @@ ka:
       navigation_menu_heading:
       navigation_search_heading:
       navigation_search_subheading:
-      popular_links:
-      popular_links_heading:
       search_text:
     metadata:
       from: დან