Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review of task-list prototype #2118

Closed
1 of 3 tasks
ImranH-GDS opened this issue Mar 23, 2022 · 3 comments
Closed
1 of 3 tasks

Code review of task-list prototype #2118

ImranH-GDS opened this issue Mar 23, 2022 · 3 comments
Assignees
@owenatgov @ImranH-GDS
Labels
community contribution task list Task list pages

Comments

@ImranH-GDS
Copy link
Contributor

ImranH-GDS commented Mar 23, 2022 •
edited by owenatgov
Loading

What

Review code for prototype created by community

Why

To check that the code is robust before we ask people to test it

Who needs to work on this

Developer

Who needs to review this

TL steering group

Done when

  • Developer does code review
  • Feed back to steering group
  • Any potential issues addressed
@owenatgov
Copy link
Contributor

Working off of this PR alphagov/govuk-frontend#2261

@owenatgov
Copy link
Contributor

Code review carried out. Will continue to monitor PR for discussion and changes and return to PR once research has concluded.

@owenatgov owenatgov reopened this Mar 29, 2022
@lfdebrux
Copy link
Member

lfdebrux commented May 5, 2022

This looks like this is done.

@lfdebrux lfdebrux closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owenatgov owenatgov

@ImranH-GDS ImranH-GDS

Labels
community contribution task list Task list pages
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lfdebrux @kellylee-gds @owenatgov @ImranH-GDS