Skip to content

Commit

Permalink
Relax constraint on rubocop-govuk dependency
Browse files Browse the repository at this point in the history
In #261 (specifically this commit [1]), most of the dependency
constraints were relaxed to use pessimistic constraints [2]. For some
reason this gem was pinned at 4.7.0, but there's no explanation in the
commit note or the PR description.

Since Rubocop seems to run OK with the latest v4 of rubocop-govuk, I
think it makes sense to relax this constraint. This should mean we don't
keep getting Dependabot PRs for every patch version of rubocop-govuk.

[1]: 0161fdf
[2]: https://thoughtbot.com/blog/rubys-pessimistic-operator
  • Loading branch information
floehopper committed Aug 2, 2023
1 parent 3404a2e commit e87722f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gds-sso.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Gem::Specification.new do |s|
s.add_development_dependency "combustion", "~> 1.3"
s.add_development_dependency "rake"
s.add_development_dependency "rspec-rails", "~> 6"
s.add_development_dependency "rubocop-govuk", "4.12.0"
s.add_development_dependency "rubocop-govuk", "~> 4"
s.add_development_dependency "sqlite3", "~> 1.5"
s.add_development_dependency "timecop", "~> 0.9"
s.add_development_dependency "webmock"
Expand Down

0 comments on commit e87722f

Please sign in to comment.