Add basic heading block #4297
Open
Add basic heading block #4297
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When govspeak only contains a YouTube video, it removes the paragraph tag, and therefore the spacing is lost. Therefore create a basic heading block that can be used instead.
leenagupte
reviewed
Oct 18, 2024
| <%= render "govuk_publishing_components/components/heading", { | ||
| text: block.data["text"], | ||
| heading_level: heading_level, | ||
| padding: true |
There was a problem hiding this comment.
I think this should be padding: to pick up the value in block.data["padding"], otherwise it will always be set to true.
Is there a time when the padding shouldn't be set to true? I'm wondering if it should always be true, and therefore not need to be set in the yaml?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
govspeakparagraph only contains a YouTube video, it removes the paragraph tag entirely, and therefore the spacing we gain from the<p>styles are lost. Therefore, the heading was right against the video. Both the heading and video were in a govspeak block. Instead, we can create a basic heading block that can be used here, instead of relying on agovspeakparagraph to give us spacing. Our gem heading component has apaddingoption which will be used to give us the spacing from the video instead.videoblock that then rendersgovspeakand aheadinggem component, if that's preferred. However I thought a generic heading block might be useful in other situations.Screenshots?
Before
After