Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breadcrumb duplication #4295

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Fix breadcrumb duplication #4295

merged 2 commits into from
Oct 18, 2024
+9 −9

Conversation

JamesCGDS
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

This PR addresses the duplication of breadcrumbs on the landing page.

Why

Trello card

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4295 October 18, 2024 13:33 Inactive
richardTowers
richardTowers approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@richardTowers richardTowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - this looks like exactly the change I thought we'd need to make.

@JamesCGDS JamesCGDS merged commit 7f67002 into main Oct 18, 2024
13 checks passed
@JamesCGDS JamesCGDS deleted the fix_breadcrumb_duplication branch October 18, 2024 13:40
@KludgeKML
Copy link
Contributor

Thanks @JamesCGDS, sorry about the mix-up!

@JamesCGDS
Copy link
Contributor Author

No worries @KludgeKML, all good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardTowers richardTowers richardTowers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JamesCGDS @KludgeKML @richardTowers @govuk-ci