Add 'See the latest data on our progress' link to homepage #4294
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-kirwan
force-pushed
the
add-see-latest-data-link-to-homepage
branch
from
6accdc5
to
de1df4e
Compare
jon-kirwan
force-pushed
the
add-see-latest-data-link-to-homepage
branch
from
de1df4e
to
a19687a
Compare
andysellick
reviewed
Oct 18, 2024
jon-kirwan
force-pushed
the
add-see-latest-data-link-to-homepage
branch
from
a19687a
to
88d3a56
Compare
Thanks for the review. Added to |
andysellick
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add 'See the latest data on our progress' link to homepage
Why
https://trello.com/c/7Sb6I491/95-see-the-latest-data-on-our-progress
How
I added the link in a separate Govspeak block right after the 'latest data' grid container block. I tried adding it directly to the grid container, but adjusting the block to fit another row was a bit fiddly. Plus, I don't think there's any need, either from an accessibility perspective or otherwise, for the link to be within the grid container itself.
Screenshots
Mobile
Desktop