Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share links variant to landing page #4282

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Oct 14, 2024

@AshGDS AshGDS self-assigned this Oct 14, 2024
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4282 October 14, 2024 15:13 Inactive
- We need to do a bit of remapping because the share_links
  components wants symbols rather than strings in its hashmaps.

Co-authored-by: Ashley Burnett <ashley.burnett@digital.cabinet-office.gov.uk>
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4282 October 14, 2024 15:47 Inactive
Copy link
Contributor

@jon-kirwan jon-kirwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me

@AshGDS AshGDS merged commit da724ee into main Oct 15, 2024
12 checks passed
@AshGDS AshGDS deleted the import-share-links-variant branch October 15, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants