Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the action link inverse option #4277

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

andysellick
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What / why

Fix the appearance of the action link on a dark background on the landing pag.e

  • previously had an override to convert the generally used inverse option to light_text, which the action link component required
  • however the action link has now been modified to use inverse so this code is no longer needed

Visual changes

Before After
Screenshot 2024-10-14 at 09 09 12 Screenshot 2024-10-14 at 09 09 18

Trello card: https://trello.com/c/GYhdvFfi/45-create-hero-block

- previously had an override to convert the generally used `inverse` option to `light_text`, which the action link component required
- however the action link has now been modified to use `inverse` so this code is no longer needed
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4277 October 14, 2024 08:10 Inactive
Copy link
Contributor

@leenagupte leenagupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@andysellick andysellick merged commit 490d747 into main Oct 14, 2024
13 checks passed
@andysellick andysellick deleted the fix-inverse-action-link branch October 14, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants