Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the second column optional in two column layouts #4274

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

richardTowers
Copy link
Contributor

@richardTowers richardTowers commented Oct 11, 2024

What

This is convenient for the case where we're only using the left column to constrain the width to two thirds (which is a common gov.uk pattern)

Why

Trello card

This is convenient for the case where we're only using the left column to constrain the width to two thirds (which is a common gov.uk pattern)
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4274 October 11, 2024 16:14 Inactive
Copy link
Contributor

@jon-kirwan jon-kirwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4274 October 18, 2024 10:25 Inactive
@richardTowers richardTowers merged commit 544f126 into main Oct 18, 2024
12 checks passed
@richardTowers richardTowers deleted the optional-right-columns branch October 18, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants