Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the skeleton of a "goals" page, as per the designs #4273

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Add the skeleton of a "goals" page, as per the designs #4273

merged 3 commits into from
Oct 18, 2024
+144 −20

Conversation

richardTowers
Copy link
Contributor

@richardTowers richardTowers commented Oct 11, 2024 •
edited
Loading

What

Adds a goals page, roughly following the designs in Figma.

Why

Trello card

Screenshots?

image

See the preview app for more details

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4273 October 11, 2024 16:02 Inactive
@leenagupte leenagupte changed the title [WIP] Add the skeleton of a "goals" page, as per the designs Add the skeleton of a "goals" page, as per the designs Oct 16, 2024
@leenagupte leenagupte marked this pull request as ready for review October 16, 2024 13:33
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4273 October 17, 2024 15:36 Inactive
leenagupte
leenagupte reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@leenagupte leenagupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise it looks good.

lib/data/landing_page_content_items/goals.yaml Outdated Show resolved Hide resolved
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4273 October 18, 2024 10:19 Inactive
leenagupte
leenagupte approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@leenagupte leenagupte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this because the skeleton is there, but this extra title above the share_links block should be removed at some point:

Screenshot 2024-10-18 at 11 50 04

@richardTowers richardTowers merged commit 6433177 into main Oct 18, 2024
12 checks passed
@richardTowers richardTowers deleted the landing-page-goals-demo branch October 18, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leenagupte leenagupte leenagupte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardTowers @leenagupte @govuk-ci