Add landing page request tests to increase test coverage #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two ways that a landing page can be loaded. One is from a content item, and one is by using the fake data in the controller. This adds modifies the request tests to use the new example landing page from content-schemas, and adds a test to check that the page renders when the fake data in the controller is used.
richardTowers
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Modifies the request tests to use the new example landing page from content-schemas, and adds a test to check that the page renders when the fake data in the controller is used.
Why
There are two ways that a landing page can be loaded. One is from a content item, and one is by using the fake data in the controller. We were only testing data from a content item.