Scaffold for Side Navigation block on landing pages #4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leenagupte
force-pushed
the
landing-pages-side-navigation-scaffold
branch
from
8caf4ed
to
984033d
Compare
leenagupte
force-pushed
the
landing-pages-side-navigation-scaffold
branch
from
984033d
to
58f2164
Compare
leenagupte
changed the title
leenagupte
force-pushed
the
landing-pages-side-navigation-scaffold
branch
from
58f2164
to
e69fd58
Compare
leenagupte
force-pushed
the
landing-pages-side-navigation-scaffold
branch
from
e69fd58
to
5cd5953
Compare
matthillco
force-pushed
the
landing-pages-side-navigation-scaffold
branch
from
5cd5953
to
d9b07fb
Compare
matthillco
force-pushed
the
landing-pages-side-navigation-scaffold
branch
from
d9b07fb
to
99833b9
Compare
leenagupte
force-pushed
the
landing-pages-side-navigation-scaffold
branch
from
c46c6b7
to
c9cc6b6
Compare
leenagupte
force-pushed
the
landing-pages-side-navigation-scaffold
branch
from
c9cc6b6
to
628db25
Compare
These links will power a side navigation block that will appear on some landing pages. The side navigation for all of the landing pages will have the same links, so rather than adding a links list to the YAML for every landing page, a shared one will be used. This is done for expediency and does not reflect how the links will eventually be handled by the CMS. The side navigation have been nested inside a links folder to logically separate them from the content items, and in case we need another list of common links.
This model reads in the same list of links for each landing page. This model will need to be modified to read side navigation links from the links hash in the content item, assuming that's where they will end up, when they become available.
The view to use the contents_list helper method to determine the active link.
matthillco
force-pushed
the
landing-pages-side-navigation-scaffold
branch
from
628db25
to
fa01d2b
Compare
matthillco
force-pushed
the
landing-pages-side-navigation-scaffold
branch
from
fa01d2b
to
f899118
Compare
KludgeKML
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the side navigation block for the landing page.
Uses the same list of links on every page that uses this block. That's fine for now because the first set of landing pages being built are linked together.
Another solution will need to be considered if landing pages start needing different sets of links in the side navigation.
Why
Trello card
How
Screenshots?